From 746e04c6241a187eeadd0adb90172f6c614ec963 Mon Sep 17 00:00:00 2001 From: Eike Kettner Date: Tue, 10 Nov 2020 22:25:46 +0100 Subject: [PATCH] Improve logging when creating preview images --- .../docspell/joex/preview/MakePreviewTask.scala | 2 +- .../docspell/joex/process/AttachmentPreview.scala | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/modules/joex/src/main/scala/docspell/joex/preview/MakePreviewTask.scala b/modules/joex/src/main/scala/docspell/joex/preview/MakePreviewTask.scala index ba9671f5..6e626b17 100644 --- a/modules/joex/src/main/scala/docspell/joex/preview/MakePreviewTask.scala +++ b/modules/joex/src/main/scala/docspell/joex/preview/MakePreviewTask.scala @@ -47,7 +47,7 @@ object MakePreviewTask { _ <- ra .map(AttachmentPreview.createPreview(ctx, preview, cfg.chunkSize)) .getOrElse( - ctx.logger.warn(s"No attachment found with id: ${ctx.args.attachment}") + ctx.logger.error(s"No attachment found with id: ${ctx.args.attachment}") ) } yield () diff --git a/modules/joex/src/main/scala/docspell/joex/process/AttachmentPreview.scala b/modules/joex/src/main/scala/docspell/joex/process/AttachmentPreview.scala index e42e67ab..57a0c170 100644 --- a/modules/joex/src/main/scala/docspell/joex/process/AttachmentPreview.scala +++ b/modules/joex/src/main/scala/docspell/joex/process/AttachmentPreview.scala @@ -57,13 +57,17 @@ object AttachmentPreview { case MimeType.PdfMatch(_) => preview.previewPNG(loadFile(ctx)(ra)).flatMap { case Some(out) => - createRecord(ctx, out, ra, chunkSize).map(_.some) + ctx.logger.debug("Preview generated, saving to database…") *> + createRecord(ctx, out, ra, chunkSize).map(_.some) case None => - (None: Option[RAttachmentPreview]).pure[F] + ctx.logger + .info(s"Preview could not be generated. Maybe the pdf has no pages?") *> + (None: Option[RAttachmentPreview]).pure[F] } - case _ => - (None: Option[RAttachmentPreview]).pure[F] + case mt => + ctx.logger.warn(s"Not a pdf file, but ${mt.asString}, cannot get page count.") *> + (None: Option[RAttachmentPreview]).pure[F] } private def createRecord[F[_]: Sync](