Merge pull request #971 from eikek/search-by-attachment-id

Allo wildcards when searching by attachment ids

modules/store/src/main/scala/docspell/store/qb/generator/ItemQueryGenerator.scala

@@ -171,12 +171,16 @@ object ItemQueryGenerator {
         tables.item.id.in(select.withSelect(Nel.of(RItem.as("i").id.s)))
 
       case Expr.AttachId(id) =>
-        tables.item.id.in(
+        val idWildcard = QueryWildcard(id)
-          Select(
+        val query =
-            select(RAttachment.T.itemId),
+          if (id == idWildcard) {
-            from(RAttachment.T),
             RAttachment.T.id.cast[String] === id
-          ).distinct
+          } else {
+            RAttachment.T.id.cast[String].like(idWildcard)
+          }
+
+        tables.item.id.in(
+          Select(select(RAttachment.T.itemId), from(RAttachment.T), query).distinct
         )
 
       case Expr.Fulltext(_) =>

modules/store/src/test/scala/docspell/store/generator/ItemQueryGeneratorTest.scala

@@ -11,6 +11,7 @@ import java.time.LocalDate
 import docspell.common._
 import docspell.query.ItemQueryParser
 import docspell.store.qb.DSL._
+import docspell.store.qb.Select
 import docspell.store.qb.generator.{ItemQueryGenerator, Tables}
 import docspell.store.queries.AttachCountTable
 import docspell.store.records._
@@ -56,4 +57,31 @@ class ItemQueryGeneratorTest extends FunSuite {
     assertEquals(cond, expect)
   }
 
+  test("attach.id with wildcard") {
+    val q    = ItemQueryParser.parseUnsafe("attach.id=abcde*")
+    val cond = ItemQueryGenerator(now, tables, Ident.unsafe("coll"))(q)
+    val expect = tables.item.id.in(
+      Select(
+        select(RAttachment.T.itemId),
+        from(RAttachment.T),
+        RAttachment.T.id.cast[String].like("abcde%")
+      ).distinct
+    )
+
+    assertEquals(cond, expect)
+  }
+
+  test("attach.id with equals") {
+    val q    = ItemQueryParser.parseUnsafe("attach.id=abcde")
+    val cond = ItemQueryGenerator(now, tables, Ident.unsafe("coll"))(q)
+    val expect = tables.item.id.in(
+      Select(
+        select(RAttachment.T.itemId),
+        from(RAttachment.T),
+        RAttachment.T.id.cast[String] === "abcde"
+      ).distinct
+    )
+
+    assertEquals(cond, expect)
+  }
 }

website/site/content/docs/query/_index.md

@@ -459,13 +459,16 @@ When negating, it finds all items that are not in a folder:
 
 The `attach.id` field is a special field to find items by providing
 the id of an attachment. This can be helpful in certain situations
-when you only have the id of an attachment. It always uses equality,
+when you only have the id or part of that of an attachment. It uses
-so all other operators are not supported.
+equality if no wildcard is present. A wildcard `*` can be used at
+beginning or end if only a part of the id is known.
 
 ```
 attach.id=5YjdnuTAdKJ-V6ofWTYsqKV-mAwB5aXTNWE-FAbeRU58qLb
+attach.id=5YjdnuTAdKJ*
 ```
 
+
 # Shortcuts
 
 Shortcuts are only a short form of a longer query and are provided for