TheAnachronism/tt-rss-viewer
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

Prefer full-res images/GIFs and promote leftover image enclosures in the Reader #38

New issue
Closed
opened 2026-08-03 18:57:12 +00:00 by TheAnachronism · 1 comment
TheAnachronism commented 2026-08-03 18:57:12 +00:00
Owner
Copy link

Parent

Part of #30

Implements docs/specs/reader-media.md.

What to build

In the Reader, prefer a full-resolution image/GIF when a better URL is already present in the article HTML, sibling image links, or image enclosures — no scrapers. Present content images in a table-safe way so Reddit-style feed tables do not hide the picture. Promote leftover image/* enclosures (including image/generic) into inline media after the body, and suppress attachment chips for promoted or preference-consumed enclosures. Keep non-image attachments (including audio) as chips. Failed images show a visible failure state with Open media and Open original. List hub Article thumbnails stay unchanged.

Extract a pure Reader media planner as needed (preference + image promotion/dedupe + shared URL helpers) and cover it with fixture-oriented tests from .scratch/rss-examples/ (especially the Reddit example). Feel reference only: branch prototype/reader-media — do not merge the throwaway package.

Acceptance criteria

  • Reddit-style preview <img> upgrades to the full-resolution GIF/image when a same-basename / size-upgrade candidate is already in HTML, links, or image enclosures
  • Duplicate image enclosures that match a shown/preferred image suppress their attachment chips
  • Leftover image enclosures not already in the HTML appear as inline images after the body
  • Content images inside feed <table> markup still appear as full-width Reader media
  • Image load failure shows Open media + Open original (not a silent blank / bare broken icon only)
  • Non-image attachments (including audio) remain labeled chips; no in-app audio player
  • List hub Article thumbnail / flavor_image behavior is unchanged
  • Planner / preference+promotion behavior is covered by tests against the RSS fixtures (or equivalent article HTML + attachments inputs)

Blocked by

None — can start immediately.

## Parent Part of #30 Implements [`docs/specs/reader-media.md`](https://git.anachronis.dev/TheAnachronism/tt-rss-viewer/src/branch/master/docs/specs/reader-media.md). ## What to build In the **Reader**, prefer a full-resolution image/GIF when a better URL is already present in the article HTML, sibling image links, or image enclosures — no scrapers. Present content images in a table-safe way so Reddit-style feed tables do not hide the picture. Promote leftover `image/*` enclosures (including `image/generic`) into inline media after the body, and suppress attachment chips for promoted or preference-consumed enclosures. Keep non-image attachments (including audio) as chips. Failed images show a visible failure state with **Open media** and **Open original**. List hub Article thumbnails stay unchanged. Extract a pure Reader media planner as needed (preference + image promotion/dedupe + shared URL helpers) and cover it with fixture-oriented tests from `.scratch/rss-examples/` (especially the Reddit example). Feel reference only: branch `prototype/reader-media` — do not merge the throwaway package. ## Acceptance criteria - [ ] Reddit-style preview `<img>` upgrades to the full-resolution GIF/image when a same-basename / size-upgrade candidate is already in HTML, links, or image enclosures - [ ] Duplicate image enclosures that match a shown/preferred image suppress their attachment chips - [ ] Leftover image enclosures not already in the HTML appear as inline images after the body - [ ] Content images inside feed `<table>` markup still appear as full-width Reader media - [ ] Image load failure shows Open media + Open original (not a silent blank / bare broken icon only) - [ ] Non-image attachments (including audio) remain labeled chips; no in-app audio player - [ ] List hub Article thumbnail / `flavor_image` behavior is unchanged - [ ] Planner / preference+promotion behavior is covered by tests against the RSS fixtures (or equivalent article HTML + attachments inputs) ## Blocked by None — can start immediately.
TheAnachronism commented 2026-08-03 19:01:09 +00:00
Author
Owner
Copy link

Resolution

Implemented on master (e45580849a):

  • Pure planner: lib/reader/reader_media_plan.dart — full-res image/GIF preference, image enclosure promote/dedupe, extractImgSrcs / stripImgs for table-safe hoist
  • Reader wiring: hoisted + promoted images with Open media / Open original failure card; remaining non-image attachments stay chips
  • Tests: test/reader/reader_media_plan_test.dart (Reddit fixture shape + promote + audio chip + hoist helpers)
  • List hub thumbnails untouched; no throwaway prototype merge; video/embeds left for #39/#40
## Resolution Implemented on `master` (`e45580849a`): - Pure planner: [`lib/reader/reader_media_plan.dart`](https://git.anachronis.dev/TheAnachronism/tt-rss-viewer/src/branch/master/lib/reader/reader_media_plan.dart) — full-res image/GIF preference, image enclosure promote/dedupe, `extractImgSrcs` / `stripImgs` for table-safe hoist - Reader wiring: hoisted + promoted images with **Open media** / **Open original** failure card; remaining non-image attachments stay chips - Tests: [`test/reader/reader_media_plan_test.dart`](https://git.anachronis.dev/TheAnachronism/tt-rss-viewer/src/branch/master/test/reader/reader_media_plan_test.dart) (Reddit fixture shape + promote + audio chip + hoist helpers) - List hub thumbnails untouched; no throwaway prototype merge; video/embeds left for #39/#40
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
beta/0.0.4
beta/0.0.3
beta/0.0.2
beta/0.0.1
alpha/0.0.2
Labels
Clear labels   
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wayfinder:grilling
HITL grilling/decision ticket

  
wayfinder:map
Wayfinder effort map

  
wayfinder:prototype
HITL prototype ticket

  
wayfinder:research
AFK research ticket

  
wayfinder:task
Unblocking manual task ticket

  
wontfix
Will not be actioned

No labels
needs-info
needs-triage
ready-for-agent
ready-for-human
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
TheAnachronism
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TheAnachronism/tt-rss-viewer#38
No description provided.