TheAnachronism/docspell
1
0
Fork 0
mirror of https://github.com/TheAnachronism/docspell.git synced 2025-03-25 16:45:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix elm-analyse issues

Browse Source
This commit is contained in:
Eike Kettner 2020-01-29 20:56:14 +01:00
parent bfd5bdb0c2
commit c504a3df42
33 changed files with 42 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
elm-analyse.json
View File

@ -3,6 +3,7 @@
"modules/webapp/target/elm-src/"
],
"checks" : {
"ImportAll": false
"ImportAll": false,
"SingleFieldRecord": false
}
}

3
modules/webapp/src/main/elm/App/Update.elm
View File

@ -130,9 +130,6 @@ updateWithSub msg model =
case req of
Internal url ->
let
newPage =
Page.fromUrl url
isCurrent =
Page.fromUrl url
|> Maybe.map (\p -> p == model.page)

2
modules/webapp/src/main/elm/Comp/ChangePasswordForm.elm
View File

@ -13,7 +13,7 @@ import Comp.PasswordInput
import Data.Flags exposing (Flags)
import Html exposing (..)
import Html.Attributes exposing (..)
import Html.Events exposing (onClick, onInput)
import Html.Events exposing (onClick)
import Http
import Util.Http

2
modules/webapp/src/main/elm/Comp/DatePicker.elm
View File

@ -16,7 +16,7 @@ module Comp.DatePicker exposing
import Date exposing (Date)
import DatePicker exposing (DateEvent, DatePicker, Settings)
import Html exposing (Html)
import Time exposing (Month(..), Posix, Zone, utc)
import Time exposing (Month(..), utc)
type alias Msg =

9
modules/webapp/src/main/elm/Comp/Dropdown.elm
View File

@ -278,15 +278,6 @@ selectActive model =
model
clearActive : Model a -> Model a
clearActive model =
{ model | available = List.map (\e -> { e | active = False }) model.available }
-- TODO enhance update function to return this info
isDropdownChangeMsg : Msg a -> Bool
isDropdownChangeMsg cm =
case cm of

2
modules/webapp/src/main/elm/Comp/EmailInput.elm
View File

@ -149,8 +149,8 @@ view values model =
]
[ text model.input
]
, renderMenu model
]
++ [ renderMenu model ]
)

2
modules/webapp/src/main/elm/Comp/EmailSettingsManage.elm
View File

@ -9,7 +9,7 @@ module Comp.EmailSettingsManage exposing
import Api
import Api.Model.BasicResult exposing (BasicResult)
import Api.Model.EmailSettings exposing (EmailSettings)
import Api.Model.EmailSettings
import Api.Model.EmailSettingsList exposing (EmailSettingsList)
import Comp.EmailSettingsForm
import Comp.EmailSettingsTable

2
modules/webapp/src/main/elm/Comp/EquipmentForm.elm
View File

@ -44,7 +44,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetEquipment t ->
( { model | equipment = t, name = t.name }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/EquipmentTable.elm
View File

@ -33,7 +33,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetEquipments list ->
( { model | equips = list, selected = Nothing }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/ItemDetail.elm
View File

@ -818,7 +818,7 @@ update key flags next msg model =
in
( { model | sentMails = sm }, Cmd.none )
SentMailsResp (Err err) ->
SentMailsResp (Err _) ->
( model, Cmd.none )

4
modules/webapp/src/main/elm/Comp/ItemList.elm
View File

@ -65,7 +65,7 @@ openAllGroups model =
update : Flags -> Msg -> Model -> ( Model, Cmd Msg, Maybe ItemLight )
update flags msg model =
update _ msg model =
case msg of
SetResults list ->
let
@ -209,7 +209,7 @@ renderItemTable model items =
renderItemLine : Model -> ItemLight -> Html Msg
renderItemLine model item =
renderItemLine _ item =
let
dirIcon =
i [ class (Data.Direction.iconFromMaybe item.direction) ] []

2
modules/webapp/src/main/elm/Comp/ItemMail.elm
View File

@ -108,7 +108,7 @@ update flags msg model =
ConnMsg m ->
let
( cm, _ ) =
--TODO dropdown doesn't use cmd!!
-- dropdown doesn't use cmd!!
Comp.Dropdown.update m model.connectionModel
in
( { model | connectionModel = cm }, Cmd.none, FormNone )

2
modules/webapp/src/main/elm/Comp/OrgTable.elm
View File

@ -35,7 +35,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetOrgs list ->
( { model | equips = list, selected = Nothing }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/PersonTable.elm
View File

@ -35,7 +35,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetPersons list ->
( { model | equips = list, selected = Nothing }, Cmd.none )

10
modules/webapp/src/main/elm/Comp/SentMails.elm
View File

@ -1,4 +1,12 @@
module Comp.SentMails exposing (..)
module Comp.SentMails exposing
( Model
, Msg
, init
, initMails
, isEmpty
, update
, view
)
import Api.Model.SentMail exposing (SentMail)
import Html exposing (..)

2
modules/webapp/src/main/elm/Comp/Settings.elm
View File

@ -58,7 +58,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg, Maybe CollectiveSettings )
update flags msg model =
update _ msg model =
case msg of
LangDropdownMsg m ->
let

2
modules/webapp/src/main/elm/Comp/SourceForm.elm
View File

@ -74,7 +74,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetSource t ->
let

2
modules/webapp/src/main/elm/Comp/SourceTable.elm
View File

@ -34,7 +34,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetSources list ->
( { model | sources = list, selected = Nothing }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/TagForm.elm
View File

@ -47,7 +47,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetTag t ->
( { model | tag = t, name = t.name, category = t.category }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/TagTable.elm
View File

@ -33,7 +33,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetTags list ->
( { model | tags = list, selected = Nothing }, Cmd.none )

2
modules/webapp/src/main/elm/Comp/UserForm.elm
View File

@ -91,7 +91,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetUser t ->
let

2
modules/webapp/src/main/elm/Comp/UserTable.elm
View File

@ -34,7 +34,7 @@ type Msg
update : Flags -> Msg -> Model -> ( Model, Cmd Msg )
update flags msg model =
update _ msg model =
case msg of
SetUsers list ->
( { model | users = list, selected = Nothing }, Cmd.none )

1
modules/webapp/src/main/elm/Main.elm
View File

@ -11,7 +11,6 @@ import Html exposing (..)
import Html.Attributes exposing (..)
import Html.Events exposing (..)
import Page
import Ports
import Url exposing (Url)

1
modules/webapp/src/main/elm/Page/Home/Data.elm
View File

@ -6,7 +6,6 @@ module Page.Home.Data exposing
, itemNav
)
import Api.Model.ItemDetail exposing (ItemDetail)
import Api.Model.ItemLightList exposing (ItemLightList)
import Comp.ItemList
import Comp.SearchMenu

1
modules/webapp/src/main/elm/Page/Home/Update.elm
View File

@ -2,7 +2,6 @@ module Page.Home.Update exposing (update)
import Api
import Browser.Navigation as Nav
import Comp.ItemDetail
import Comp.ItemList
import Comp.SearchMenu
import Data.Flags exposing (Flags)

1
modules/webapp/src/main/elm/Page/Home/View.elm
View File

@ -1,6 +1,5 @@
module Page.Home.View exposing (view)
import Comp.ItemDetail
import Comp.ItemList
import Comp.SearchMenu
import Html exposing (..)

2
modules/webapp/src/main/elm/Page/ItemDetail/Update.elm
View File

@ -35,5 +35,5 @@ update key flags next msg model =
in
update key flags next (ItemDetailMsg lmsg) model
ItemResp (Err err) ->
ItemResp (Err _) ->
( model, Cmd.none )

2
modules/webapp/src/main/elm/Page/Register/Update.elm
View File

@ -106,7 +106,7 @@ update flags msg model =
, cmd
)
SubmitResp (Err err) ->
SubmitResp (Err _) ->
( model, Cmd.none )

7
modules/webapp/src/main/elm/Page/Upload/Data.elm
View File

@ -94,13 +94,6 @@ uploadAllTracker =
"upload-all"
isInitial : Model -> Bool
isInitial model =
Set.isEmpty model.loading
&& Set.isEmpty model.completed
&& Set.isEmpty model.errored
isDone : Model -> Bool
isDone model =
List.map makeFileId model.files

4
modules/webapp/src/main/elm/Page/Upload/View.elm
View File

@ -48,7 +48,7 @@ view mid model =
renderErrorMsg : Model -> Html Msg
renderErrorMsg model =
renderErrorMsg _ =
div [ class "row" ]
[ div [ class "sixteen wide column" ]
[ div [ class "ui large error message" ]
@ -63,7 +63,7 @@ renderErrorMsg model =
renderSuccessMsg : Bool -> Model -> Html Msg
renderSuccessMsg public model =
renderSuccessMsg public _ =
div [ class "row" ]
[ div [ class "sixteen wide column" ]
[ div [ class "ui large success message" ]

7
modules/webapp/src/main/elm/Ports.elm
View File

@ -1,4 +1,9 @@
port module Ports exposing (..)
port module Ports exposing
( removeAccount
, setAccount
, setAllProgress
, setProgress
)
import Api.Model.AuthResult exposing (AuthResult)

4
modules/webapp/src/main/elm/Util/Http.elm
View File

@ -192,10 +192,10 @@ jsonResolver decoder =
Http.NetworkError_ ->
Err Http.NetworkError
Http.BadStatus_ metadata body ->
Http.BadStatus_ metadata _ ->
Err (Http.BadStatus metadata.statusCode)
Http.GoodStatus_ metadata body ->
Http.GoodStatus_ _ body ->
case D.decodeString decoder body of
Ok value ->
Ok value

3
modules/webapp/src/main/elm/Util/String.elm
View File

@ -12,9 +12,6 @@ crazyEncode str =
let
b64 =
Base64.encode str
len =
String.length b64
in
case String.right 2 b64 |> String.toList of
'=' :: '=' :: [] ->